Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add storages editor to input schema specification #1211

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

MFori
Copy link
Contributor

@MFori MFori commented Sep 12, 2024

Add new input schema editor values for string properties to input schema specification.
This is based on this issue: https://github.com/apify/apify-core/issues/12871 and part of

This one will be merged as the last one.

Screenshot 2024-09-12 at 8 47 10

@MFori MFori requested review from gippy and TC-MO September 12, 2024 06:54
@MFori MFori self-assigned this Sep 12, 2024
@MFori MFori added the t-console Issues with this label are in the ownership of the console team. label Sep 12, 2024
@github-actions github-actions bot added this to the 98th sprint - Console team milestone Sep 12, 2024
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MFori added a commit to apify/apify-shared-js that referenced this pull request Sep 13, 2024
This PR introduce new input schema `editor` values for `string`
property:
`dataset`, `keyValueStore` and `requestQueue` based on issue:
apify/apify-core#12871

The editor will show storage inputs enabling users to search and select
storage, then the storage id is taken as field value.
Input PR waiting for this:
apify/apify-core#17521
Docs PR: apify/apify-docs#1211
@MFori MFori added the documentation Improvements or additions to documentation. label Sep 27, 2024
@MFori MFori merged commit 6c61eef into master Oct 4, 2024
7 checks passed
@MFori MFori deleted the feat/input-schema-storages-editor branch October 4, 2024 07:21
MFori added a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. t-console Issues with this label are in the ownership of the console team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants